pinterest-for-woocommerce

pinterest-for-woocommerce copied to clipboard

While reviewing #118, I noticed that the `ProductsXmlFeed` class repeats this same portion of code multiple times: ```php return '' . $variable . ''; ``` ```php return ''; ``` I...

JPry

Ensure redux reducer functions do not mutate state or parameters

2

### Describe the bug: As highlighted by @ecgan in a recent review: https://github.com/saucal/pinterest-for-woocommerce/pull/100/files/dd48da02af9a24ba2a59e86eedf11fb3a6d30447#r674148315 https://redux.js.org/style-guide/style-guide#do-not-mutate-state https://redux.js.org/usage/troubleshooting#never-mutate-reducer-arguments Looks like both the onboarding reducer (`setup-guide/app/data/settings`) and the catalog sync reducer (`catalog-sync/app/data/reports`) both mutate...

haszari

useBodyClasses hook is too tightly coupled to the client components.

1

As discussed [here](https://github.com/saucal/pinterest-for-woocommerce/pull/7#pullrequestreview-646482552) This `useBodyClasses` hook is problematic and too tightly coupled to the components. The hook should not know anything about how/where it's used (e.g. `style` param and all...

ksere

There's increased coupling between `pinterest_data` option, `Crypto` class, and main plugin class. I think it would be clearer and simpler if: - Main plugin class is responsible for all option...

ksere

Save to Pinterest button: not rendered within product image and blocking "sale" text in mobile view with storefront theme

3

### Describe the bug: Please refer to the screenshot below, the "Save to Pinterest" button is rendered above the above the product image and blocking the "Sale!" text.  Note...

ecgan

Setup guide component modifies `document.body` classes (outside component) in a side effect - can this be avoided?

1

As discussed [here](https://github.com/saucal/pinterest-for-woocommerce/pull/7#pullrequestreview-646482552) > Need to justify why components need to affect the DOM outside the component (body classes etc) - this is unusual. Ideally the component wouldn't need to...

ksere

As discussed [here](https://github.com/saucal/pinterest-for-woocommerce/pull/7#pullrequestreview-646482552) > Some components are still using HOCs (e.g. withDispatch) - should consistently use hook style throughout the plugin.

ksere

Save to Pinterest not working for `All Products` block

2

The pin button is not working in product blocks - for example, the Storefront homepage layout that heavily uses blocks. We can handle that as follow up - this is...

ksere

As originally requested [here](https://github.com/saucal/pinterest-for-woocommerce/pull/19#discussion_r648736457) the new `All products` block should correctly trigger a tracking event when a product is added to the cart. Also related: #13

ksere

As discussed [here](https://github.com/saucal/pinterest-for-woocommerce/pull/19#pullrequestreview-681184031), ideally we should not print the tracking tag directly [as we currently do](https://github.com/saucal/pinterest-for-woocommerce/pull/19/files#diff-76b4e05a2bd981fd7244a32e751ea4b6bd3d4e0f63885d00d4ee915ab2fb6443R402). An ideal solution would also avoid the need for ignoring coding standards on those...

ksere