Angela Wong

Results 10 comments of Angela Wong

@nightnei Thank you for the detailed explanations! I see one shortcoming with the current approach, and that is the tracking event is delayed till _after_ all the required server calls...

LGTM! Thanks for clearly warning against merging before the other related feature is ready and for converting the `.jsx` into `.tsx` as well! The "Add Email" button is now shown...

>I have a followup pull request (for a different task) incoming that will refactor the message into its own component @AllTerrainDeveloper It would make sense to do the refactoring in...

@AllTerrainDeveloper Other than the minor comment I left regarding tracking, I also found a weird issue, where when user gets redirected to the email comparison page, the Professional Email card...

@AllTerrainDeveloper I ran into an issue while reviewing the [other PR](https://github.com/Automattic/wp-calypso/pull/68435) on the Email Management page changes. When we remove all mailboxes, the non-owner will see the Email Comparison screen...

@AllTerrainDeveloper Confirming that the email forward link has been hidden for non-owners.

>Could you outline the steps to reproduce this? @fredrikekelund Hm... looks like I'm also unable to reproduce this. Initially I thought this could be related to the sandbox store, but...

I do agree that the link for setting up Email Forwarding is so subtle that the potential conversion impact may not actually be a valid concern. In the interest of...

>I couldn't actually reproduce the incorrect data, but @wongasy reported it here: https://github.com/Automattic/wp-calypso/pull/87474#issuecomment-1958461911. I suspect the faulty data I saw were sent before this commit https://github.com/Automattic/wp-calypso/pull/87474/commits/9fba17ba1bb4f1ad282f6be44f33cd627d796be3. Looks like we are...

>In general, sometimes less code looks harder to read, and readability is much more critical than number of lines I agree. Although, in this case, I do find the changes...