xurenhe comments

Results 7 comments of


                                            xurenhe

[CALCITE-4694] Specify custom ProjectFactory for RelOptMaterialization

LGTM~ Define a new constructor to support custom wrap-project for scan of target.

[CALCITE-4982] NonNull field is pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

Hi @NobiGo Are you going on reviewing this pr?

[CALCITE-4982] NonNull field is pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

@libenchao Thank you for reminding me, and I almost forgot this issue. I will update this pr as soon as possible.

[CALCITE-4982] NonNull field is pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

@libenchao This issue/pr was so long that it took me a little time to review it. Two solutions: 1. Avoid pushing down with the operand of coalesce's operator 2. Keep...

[CALCITE-4982] NonNull field is pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

Add default config: PreserveExprCondition Shouldn't push non-null field, which is wrapped by CAST's operator. Hi @libenchao Please review this pr again, thanks a lot.

[CALCITE-4982] NonNull field is pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

In my opinion, this case only works on in CALCITE's optimizer or validator, which some expresion only change nullable attribute. we couldn't write an sql `cast(c1 as not integer)`, and...

[CALCITE-4982] NonNull field is pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

Hi @libenchao PR is ready, and could you take your time to review it again, thanks.