Wojciech Maj comments

Results 257 comments of


Wojciech Maj

use "ISO-8601" as calendarType but set first day of the week to Sunday

Week numbers are calculated differently depending on calendar type. Not sure how could we mark week numbers if we introduce a separate options for week start weekday.

build error: cant's resolve 'canvas' in '...\.pnpm\...\build' when use pnpm

I believe your problem isn't as much about pnpm as about running React-PDF server-side, which makes no sense. You can't render canvas on the server.

font is blurry in tablet sized iframe (width : 800px)

I'm unable to reproduce that. Maybe your iframe forces the page to resize via CSS because you didn't specify `Page`'s component `width`, hence the blurring?

react-pdf v6 Module parse failed: Unexpected character '#'

Hmmm, tried running 6.0.0-beta.3 with my Create React App 5 sample app and it went without any issues. I suspect react-scripts 3.4.4 might be a bit too old 🤔

react-pdf v6 Module parse failed: Unexpected character '#'

Maybe it's possible to update Babel manually? I hope they didn't pin Babel version in CRA?

iOS 16 upgrade -> No longer validates or uploads to Testflight

I'm happy to say I've built two apps using RN 0.70 + Xcode 14, pushed them to TestFlight, got the warning this thread is all about, submitted them, and they...

color-contrast incorrectly calculating background color of an element in closed `<details>`

It appears that the problem is in `filteredRectStack` function, which in this case, returns `[span, button, main, body, html]`.

fix(color-contrast): do not calculate contrast of elements inside closed details element

Remember that `` remains visible even on closed `` element.

Support React 17

Looks like it does not remove these methods after all! Postponed to React 18+.

Support React 17

Yes it could. I'm happily using react-vis with React 17 in production on a large scale commercial application with zero complaints. Hell, preparing to upgrade to React 18 as soon...