Wojciech Maj

Results 257 comments of Wojciech Maj

Is there an easy way to reproduce this? Specific browser, browser version, specific code?

I believe minDate should prevent the user from submitting a date that's smaller than minDate 🤔 If it doesn't, I'd consider this a bug. By the way, there's [React-DateTimeRange-Picker](https://github.com/wojtekmaj/react-datetimerange-picker/) too...

Hey @amansur, I think it's a neat idea. I'll make sure to implement this :)

In other words, isOpen only works when changed, but initial value is ignored?

I see. That's actually very interesting case. An edge case IMO. Forcing this state to be always matching the one from props instead of being updated on mount and on...

I think that's an awesome idea. Would you please share some example implementation in some popular solution?

Thank you! That makes it more clear for me.

What do you mean "in a modal"? Do you have time to create reproducible example on CodeSandbox?

It looks like MUI is messing the styles up. Safari has nothing to do with it, on Chrome it's the same story. Here it is compared to native ``: https://codesandbox.io/s/react-datetime-picker-mui-and-native-dialogs-r6vnf9...

I think we could use margin-block-start to fix this. But margin-left would need to stay for compatibility reasons, so margin-block-end would need to reset it.