Wojciech Tyczynski
Wojciech Tyczynski
/remove-lifecycle stale /lifecycle frozen
/remove-lifecycle stale > I'm taking no action on this in ~2 years as a sign that it's no longer that important I think it is important. It just means that...
/remove-lifecycle stale /lifecycle frozen
> @wojtek-t would you consider this enhancement from PRR perspective complete for alpha while we finalize some of the implementation details? I am asking this assuming today is PRR freeze....
Given lack of SIG agreement up until now, it's probably too late to get it into 1.34.
Events reporting (assuming you use libraries from client-go - recorder etc.) is asynchronous anyway
https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/job/job_controller.go#L485-L487 is most probably the offender - without looking deeper into the code, this should most probably go to the worker function /cc @mimowo @alculquicondor
> /assign @wojtek-t Just for posterity - this proposal LGTM too.
One more request for unit test - other than that LGTM
/lgtm /approve