test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Move all jobs to using logexporter and make it default

Open shyamjvs opened this issue 8 years ago • 26 comments

Ref https://github.com/kubernetes/kubernetes/issues/48513

Logexporter has been stabilized after multiple fixes. It's been enabled in most of our scalability jobs and is working just fine. E.g: https://k8s-testgrid.appspot.com/google-gce-scale#gce-scale-performance (our 5k-node test, where the time taken for logdump has reduced from >4hr to <20min) https://k8s-testgrid.appspot.com/google-gce-scale#gce (our 100-node test, where the time taken for logdump has reduced from 10min -> 2min) https://k8s-testgrid.appspot.com/google-gce-scale#gci-gce

It does the dumping cleanly (in parallel across all nodes in the cluster). And besides saving time, it also saves a lot of diskspace/inodes in the job containers. We should move all our jobs to using it (except ones from release branches which don't have the logexporter changes yet).

cc @fejta @kubernetes/test-infra-maintainers @kubernetes/sig-scalability-misc

shyamjvs avatar Aug 10 '17 19:08 shyamjvs

how about enable them for canary jobs first, if they work we can flip the flag to be default enabled.

krzyzacy avatar Aug 10 '17 19:08 krzyzacy

That's a good idea. But we don't yet want to enable it by default as it wouldn't work on release branch jobs.

shyamjvs avatar Aug 10 '17 19:08 shyamjvs

@krzyzacy Can you bump prow image with the new kubekins image I changed in https://github.com/kubernetes/test-infra/pull/4187? This is required to enable logexporter for all gke jobs. Thanks.

shyamjvs avatar Aug 25 '17 11:08 shyamjvs

@shyamjvs you can run ./experiment/bump_e2e_image.sh and push the commits

krzyzacy avatar Aug 25 '17 16:08 krzyzacy

Done - thanks https://github.com/kubernetes/test-infra/pull/4197

shyamjvs avatar Aug 25 '17 17:08 shyamjvs

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta. /lifecycle stale

fejta-bot avatar Jan 03 '18 19:01 fejta-bot

/remove-lifecycle stale /lifecycle frozen

@krzyzacy Does something stop us from making logexporter the default for all jobs now? I can think of none. Previously we didn't have logexporter support in older k8s releases, but now those jobs are against newer releases.

shyamjvs avatar Jan 09 '18 10:01 shyamjvs

@shyamjvs not really for logexporter, but I'd like to see the logic in log-dump.sh can go into kubetest

krzyzacy avatar Jan 09 '18 19:01 krzyzacy

/remove-lifecycle frozen

fejta avatar Jan 25 '18 07:01 fejta

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Apr 25 '18 08:04 fejta-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten /remove-lifecycle stale

fejta-bot avatar May 25 '18 08:05 fejta-bot

/remove-lifecycle stale

On Fri, May 25, 2018, 1:52 AM fejta-bot [email protected] wrote:

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta https://github.com/fejta. /lifecycle rotten /remove-lifecycle stale

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kubernetes/test-infra/issues/4046#issuecomment-391987067, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4Bq1jl-L30z1WMDMB7HaMU7pifLubKks5t18Y3gaJpZM4Oz4JT .

BenTheElder avatar May 25 '18 16:05 BenTheElder

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

fejta-bot avatar Jun 24 '18 16:06 fejta-bot

/remove-lifecycle stale /reopen

On Sun, Jun 24, 2018, 09:46 k8s-ci-robot [email protected] wrote:

Closed #4046 https://github.com/kubernetes/test-infra/issues/4046.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kubernetes/test-infra/issues/4046#event-1697665785, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4Bq_tmklxtEORKSvG6g1BvIrKYDM7Aks5t_8JmgaJpZM4Oz4JT .

BenTheElder avatar Jun 24 '18 19:06 BenTheElder

@BenTheElder: you can't re-open an issue/PR unless you authored it or you are assigned to it.

In response to this:

/remove-lifecycle stale /reopen

On Sun, Jun 24, 2018, 09:46 k8s-ci-robot [email protected] wrote:

Closed #4046 https://github.com/kubernetes/test-infra/issues/4046.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kubernetes/test-infra/issues/4046#event-1697665785, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4Bq_tmklxtEORKSvG6g1BvIrKYDM7Aks5t_8JmgaJpZM4Oz4JT .

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 24 '18 19:06 k8s-ci-robot

https://github.com/kubernetes/test-infra/issues/4425#issuecomment-399781968

BenTheElder avatar Jun 24 '18 19:06 BenTheElder

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

fejta-bot avatar Jul 24 '18 20:07 fejta-bot

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Oct 22 '18 21:10 fejta-bot

/remove-lifecycle stale /lifecycle frozen

wojtek-t avatar Oct 24 '18 07:10 wojtek-t

/remove-lifecycle frozen I'm taking no action on this in ~2 years as a sign that it's no longer that important

spiffxp avatar Sep 11 '20 02:09 spiffxp

/sig scalability

BenTheElder avatar Sep 11 '20 04:09 BenTheElder

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Dec 10 '20 04:12 fejta-bot

/remove-lifecycle stale

I'm taking no action on this in ~2 years as a sign that it's no longer that important

I think it is important. It just means that we don't have enough capacity to push all important things...

wojtek-t avatar Dec 10 '20 15:12 wojtek-t

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Mar 10 '21 15:03 fejta-bot

/remove-lifecycle stale /lifecycle frozen

wojtek-t avatar Mar 10 '21 16:03 wojtek-t

/kind cleanup

spiffxp avatar Oct 01 '21 19:10 spiffxp