Santiago Fraire Willemoes
Santiago Fraire Willemoes
That makes sense. If you say "Yes I want pre-commit" and cz fails to install/configure it, then it shouldn't pass silently. The user must fix pre-commit first and then continue...
Quite interesting indeed, please open a PR so we can discuss it there!
Related to https://github.com/commitizen-tools/commitizen/pull/522 Introducing `chardet` is creating some problems. I think if confidence is not enough (~.85) maybe we should propagate the error. @jenstroeger do you think you can provide...
Yes, I think the unicode tries could be encapsulated in a function `try_decode` so we keep the logic there. But the code looks good 👍🏻
I'm fine with it, just wondering how to include this. We also have the signed commits with `-s`, I was wondering if we should move forward with ``` cz check...
fine by me as well :+1:
> A question on this though - whilst commitizen does not support dev versions, will it still be able to successfully parse a PEP440-compatible version that includes a dev version,...
Sounds good to me, we can start with a draft. What kind of conditions were you thinking about @manang ? I think there should be no problem with this
LGTM, may I ask a new test case to be added for this? @Lee-W what do you think?