commitizen icon indicating copy to clipboard operation
commitizen copied to clipboard

fix: capitalize types in default change_type_order

Open lobotmcj opened this issue 3 years ago • 5 comments

Description

See #402

Checklist

  • [ ] Add test cases to all the changes you introduce
  • [X] Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • [X] Test the changes on the local machine manually
  • [x] Update the documentation for the changes

Expected behavior

See #402

Steps to Test This Pull Request

See #402

Additional context

See #402

lobotmcj avatar Jul 11 '21 20:07 lobotmcj

Codecov Report

Merging #403 (f9dac08) into master (764861f) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   98.25%   98.30%   +0.04%     
==========================================
  Files          39       39              
  Lines        1551     1590      +39     
==========================================
+ Hits         1524     1563      +39     
  Misses         27       27              
Flag Coverage Δ
unittests 98.30% <100.00%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/bump.py 100.00% <100.00%> (ø)
commitizen/cmd.py 100.00% <100.00%> (ø)
commitizen/commands/changelog.py 96.62% <100.00%> (+0.03%) :arrow_up:
commitizen/commands/commit.py 98.43% <100.00%> (+0.02%) :arrow_up:
commitizen/commands/init.py 91.66% <100.00%> (ø)
commitizen/config/json_config.py 100.00% <100.00%> (ø)
commitizen/config/yaml_config.py 100.00% <100.00%> (ø)
commitizen/defaults.py 100.00% <100.00%> (ø)
commitizen/exceptions.py 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 11 '21 20:07 codecov[bot]

LGTM, may I ask a new test case to be added for this? @Lee-W what do you think?

woile avatar Jul 12 '21 06:07 woile

LGTM as well. But might need some test case to verify the behavior

Lee-W avatar Jul 13 '21 09:07 Lee-W

@Woile I've rebased it and add test cases for it. Could you please take a look? Thanks!

Lee-W avatar Mar 30 '22 08:03 Lee-W

@Woile I've rebased it and add test cases for it. Could you please take a look? Thanks!

thank you, sir

lobotmcj avatar Mar 30 '22 19:03 lobotmcj

Sounds good

woile avatar Aug 14 '22 07:08 woile