Walaa Eldin Moustafa

Results 65 comments of Walaa Eldin Moustafa

Let us not use `Dataset` as it is not a standard term. `Table` maybe more appropriate, but I understand you want to use it elsewhere, but we can find an...

Can we eliminate ```java if (coralCatalog != null) { ... } else { ... } ``` that we are currently using everywhere and use some adapter class instead?

There are quite a fiew overlapping wrappers: ``` CoralTable --> HiveCoralTable / IcebergCoralTable HiveTable / HiveViewTable IcebergTable ``` The layering is conceptually unclear. Can we simplify this and merge a...

I have considered a few design options and this seems to make the most sense: ```java interface CoralTable extends ScannableTable class HiveTable implements CoralTable class IcebergTable implements CoralTable ```

> I have considered a few design options and this seems to make the most sense: > > ```java > interface CoralTable extends ScannableTable > class HiveTable implements CoralTable >...