Walaa Eldin Moustafa
Walaa Eldin Moustafa
I think if we want to do this, we might want to always leverage a `RelBuilder` like [this](https://github.com/linkedin/coral/blob/bbf5f1587d7f6cb40dc396d6ff20a64136ea8306/coral-common/src/main/java/com/linkedin/coral/common/HiveRelBuilder.java#L59) (which actually triggers the `PEEK_FIELDS_NO_EXPAND` path). Also if we do it, I...
There is a discussion on this in #451. FYI @caicancai.
Should the precision be patched in Coral or Calcite? Should it go in LHS or IR? Sounds Calcite + IR is the correct answer based on recent discussions?
Ok let me clarify. For Coral vs Calcite: I was under the impression that Hive INT and LONG will be converted to Calcite INT and LONG and then Calcite is...
Thanks for the PR. I think it still needs some more work: 1- Conversion from SqlNode to RelNode. 2- Conversion from RelNode to SqlNode.
Yes, Trino to Coral is not fully supported yet and it is work in progress.
The description is not quite adding up since "unions" are not a thing in Coral. Could you rewrite the description using "records" which is the actual primitive? That would help...
If you really need to use unions for the description, you may talk about unions in the Hive type system, then records in the Coral type system but you have...
Thanks Sumedh for the PR! Both `coral-trino` and `coral-spark` contain integration tests of this nature and also structure how to provide the input and assert output in a consistent way....
Can we unify things somehow? It is not clear to me when to use either side. Also there is a bunch of repeated code.