Yoshiyuki Kurauchi comments

Results 33 comments of


                                            Yoshiyuki Kurauchi

Test end-to-end ping/curl following attach/modify/delete

FYI #174 partially resolved this.

add an example of marshalling using reflect

I'm generally not in favor of using reflection in the packet processing, as there may be a concern in performance. Could you add some benchmarks to show the difference?

Add tests for IE helper methods

## uint32 - [x] AggregatedURRID - [x] AveragingWindow - [x] CumulativeRateRatioMeasurement - [x] CumulativeRateRatioThreshold - [x] DSTTPortNumber - [x] EthernetFilterID - [x] EventQuota - [x] EventThreshold - [ ] FailedRuleID...

Extension Header Type List length field is one byte

Ahah what a trap! 3GPP really likes to annoy us with such things :) Thanks for reporting. I'll check and fix it hopefully in a few days.

Extension Header Type List length field is one byte

Yeah it’d be some unusual work. I have some ideas on how to make it work but didn’t have time to try. Maybe next week I can do.

Extension Header Type List length field is one byte

@oicnysa I've added exceptions for Extension Header Type List in parsing/marshaling common IE structure at b24e7e8033b7306e9edb91a61a86923c137098c4. Though the length field of the structure is still of type `uint16`, it should...

ADNP in PFDContents

Seems so (and other fields should also be updated). I think we rather want to define a dedicated struct for them to be more kind, like; ```go type PFDContentsFields struct...

Calculate length automatically when packing UDP with upper layers

I found manual calculation is also used in [examples/dhcprequest.py](https://github.com/kbandla/dpkt/blob/master/examples/dhcprequest.py). We need to be sure of that when addressing this issue.

"TypeError: %x format: a number is required, not str" at _parsemac(), when using findalldevs()

Did you try: ``` return ':'.join(['%02x' % ord(i) for i in mac]) ``` instead of: ``` return ':'.join(['%02x' % i for i in mac]) ``` at 'File "/pcappy/__init__.py", line 227,...

update the mme handler to get SGW IP address

Why do you think it is necessary?