ADNP in PFDContents

[john721]

Hi,

In go-pfcp/ie/pfd-contents.go , the type of this field may need to be []byte. AdditionalDomainNameAndProtocol []string

According to 29.244, Figure 8.2.39-4, this field is a compound field which contains length field. So, I think it should not be of type []string, but []byte instead?

[wmnsk]

Seems so (and other fields should also be updated). I think we rather want to define a dedicated struct for them to be more kind, like;

type PFDContentsFields struct {
	// ...
	AdditionalDomainNameAndProtocol []*AdditionalDomainNameAndProtocol
}

type AdditionalDomainNameAndProtocol struct {
	Length     uint16
	DomainName string
	Protocol   string
}

I'll have a closer look another time, maybe next month.

[wmnsk]

resolved in https://github.com/wmnsk/go-pfcp/pull/106