wanglei01

Results 41 comments of wanglei01

index拿出不正确的timer不是因为append。 是因为https://github.com/siddontang/go/issues/12 有数据竞争, w.tv1[index] = vec[0:0:defaultTimerSize]以后再 tv[i] = append(tv[i], t) 和 for _, t := range vec { 引用的是相同底层数据,但for语句又没有上锁

``` Go w.tv1[index] = make([]*timer, 0, defaultTimerSize) ``` or ```Go var pool = &sync.Pool{ New: func() interface{} { return make([]*timer, 0, defaultTimerSize) }, } ``` ```Go w.tv1[index] = pool.Get().([]*timer) ```...

another one, should add sync/atomic https://github.com/siddontang/go/blob/2b7082d296ba89ae7ead0f977816bddefb65df9d/time2/wheel.go#L145 https://github.com/siddontang/go/blob/2b7082d296ba89ae7ead0f977816bddefb65df9d/time2/wheel.go#L194 https://github.com/siddontang/go/blob/2b7082d296ba89ae7ead0f977816bddefb65df9d/time2/wheel.go#L204

@arronwy Sorry for the late reply. This is how containerd handles Command of OCI specs: https://github.com/containerd/containerd/blob/main/pkg/cri/opts/spec.go#L54-L76 And handles CWD: https://github.com/containerd/containerd/blob/main/pkg/cri/server/container_create_linux.go#L145-L149 We need to add Entrypoint compatibility.

A related question: https://github.com/containerd/containerd/issues/7229

@huoqifeng Yes, this is in progress. Do you have an image available there to verify this?

In Progress https://github.com/wllenyj/containerd/commit/fff8e80c320a030500e61258ce46e113d336b8ba Currently skopeo+umoci, I cannot find how to get image.config, so can't get Entrypoint.

I'm ok for all. However, if option 1 is used, how can we be compatible with it when the contaienrd is landed.

Will the new commit differ from the default flags of the original code? Does this mean that a major version number needs to be upgraded? And there are interfaces removed.

Hi, @little-dude Is it possible to release a new version before you AFK?