Wouter Knoben

 Diagnosis: - `x2` (water exchange parameter) is determined by relative fullness of store S2 (`R` in original GR4J paper), which is controlled by `x3`(maximum routing store depth) - Empty...

Numerical solutions don't always return physically realistic values. Suggestion: - Remove constraints from individual flux functions - Build in constraints as part of the solver, where we (1) check if...

Add internal checks & corrections for topology

3

I ran into an issue where some river segments in my domain shapefile have length 0 and this leads to a mizuRoute error: ``` FATAL ERROR: init_data/init_ntopo/check_river_properties/reach length for reach...

X4 is multiplied inside the `uh_2_full` function: https://github.com/wknoben/MARRMoT/blob/7f86958540012b06a4555fb0530d62b1ece28622/MARRMoT/Models/Unit%20Hydrograph%20files/uh_2_full.m#L34 But also in the model function: https://github.com/wknoben/MARRMoT/blob/7f86958540012b06a4555fb0530d62b1ece28622/MARRMoT/Models/Model%20files/m_07_gr4j_4p_2s.m#L63 Problem: we end up with a time base for the hydrograph of 2*2*X4 Solution: remove...

Text refers to `m_46_classic_12p_4s` instead of `m_47_IHM19_16p_4s`. Reported by: Diana Spieler

https://github.com/wknoben/MARRMoT/blob/bfeca6d5361154a44a4a57fe3fb9dd3117d7c67e/MARRMoT/Models/Flux%20files/saturation_12.m#L19 This will return Inf but should return 0.