Will Harney

Results 11 comments of Will Harney

The minimal-change approach to this would be to perform static analysis to try to resolve values and determine whether or not they are primitives. However, a more radical approach might...

@lisa-mcgerr it seems like you may have not set up the access token correctly. But, as per @johnboxall's [comment](https://github.com/SalesforceCommerceCloud/pwa-kit/issues/363#issuecomment-1605122112), you should be able to do this by following the [SLAS...

Running `npm install global-jsdom jsdom lwc && node -r global-jsdom/register -e 'import("lwc").then(()=>console.log("success"))'` only succeeds for v16+.

> Also: I'm wondering if it's about time we added some real TypeScript tests somewhere. Nothing too fancy, just something to confirm that the types compile the way we expect...

> 1. We need to have at least some minimal tests, preferably in the `lwc` package, that test the types our users are likely to use. I added it under...

> It would probably be an effort on our end since we have a lot of tricky jest.config.js files and custom matchers, but it should be doable to switch over....

I've pushed a branch, [todone](https://github.com/salesforce/lwc/compare/todone), which adds a comment `// TODO: Is this TODOne?` before all of the TODO comments with currently closed issues. If you don't want to search...

That's an error output; running eslint caused the node process to crash. I'm not sure why that would happen; you may want to re-install your dependencies and try again: `yarn...

Here's a list of all the current TODOs in published packages. * #1136 * https://github.com/salesforce/lwc/blob/cab5e419494975657246f0543005f4ed521cc139/packages/@lwc/template-compiler/src/parser/index.ts#L1716-L1722 * #1150 * https://github.com/salesforce/lwc/blob/cab5e419494975657246f0543005f4ed521cc139/packages/@lwc/template-compiler/src/codegen/codegen.ts#L129-L135 * #1164 * https://github.com/salesforce/lwc/blob/cab5e419494975657246f0543005f4ed521cc139/packages/@lwc/engine-core/src/framework/rendering.ts#L521-L527 * https://github.com/salesforce/lwc/blob/cab5e419494975657246f0543005f4ed521cc139/packages/@lwc/synthetic-shadow/src/faux-shadow/shadow-root.ts#L85-L91 * #1252 * https://github.com/salesforce/lwc/blob/cab5e419494975657246f0543005f4ed521cc139/packages/@lwc/engine-dom/src/apis/is-node-from-template.ts#L47-L53 *...

What are the behavioral differences (in ESM land, outside the LWC context) between `export default const Foo = ...` vs `export { default as Foo }`? In particular, when we...