wittypluck

Results 22 comments of wittypluck

I cannot comment on PR #115267 any more, but have resolved the comment over there

Thanks, coverage and conflicts should be solved now.

Hello, would it be possible to validate/merge this PR for the April release? Thanks 😊

Hello @gjohansson-ST , I have reworked the code based on your suggestions: - moved uptime sensor code to `GlancesDataUpdateCoordinator` - removed most of the code specific to the uptime sensor...

One test is failing but is not related to this PR (ruff-format tests/components/light/common.py)

Hello @gjohansson-ST , I think I have addressed all comments, let me know if you need more information. Thanks!

I have created the documentation update PR

So I have tested the implementation with the `now` sensor locally, and unfortunately it does not solve the question of the variation of uptime in Home Assistant. There is an...

Could you maybe explain a bit more what your concern is with the implementation ? There are several other uptime sensors in HA based on `utcnow()` such as : https://github.com/home-assistant/core/blob/d1209934776d343d9e16959126f47373608066c9/homeassistant/components/unifi/sensor.py#L92...