Jürgen Wißkirchen
Jürgen Wißkirchen
I managed to workaround - so I can run my Gateway app as native image again - by - replacing registerBeanDefinition callback with a factoryMethod - defining a bean for...
@spencergibb @joshlong Just added my announced PR https://github.com/spring-cloud/spring-cloud-gateway/pull/3193. I am happy to elaborate on your review comments and also add test(s) if you need. Just instruct me :-)
now added and imported RuntimeHintsRegistrar to support externalized configs as the one I tested with below (properties-style for readability :-)). RuntimeHints are definitely not complete yet though - e.g. I...
@spencergibb May I politely request your review on this?
@ryanjbaxter @OlgaMaciaszek Just saw Spencer leaving to Cockroach Labs 😢 That may explain there was no progress in this PR. Do you want to proceed with it? Still it will...
@ryanjbaxter: Thanks for the reply. > I think you want to check who was the author of that tweet, it doesn’t appear to be @spencergibb 😉 No :-) I authored...
@spencergibb @OlgaMaciaszek I just resolved the merge conflicts by transferring adapted methods (mainly making `operationArgs` now `Map`) inside `GatewayMvcPropertiesBeanDefinitionRegistrar::routerFunctionHolderSupplier` (and subordinated methods) to the `RouterFunctionHolderFactory` in my PR-branch. maven verify...
> Still want @OlgaMaciaszek to look Yes, sure!
> Hello @wisskirchenj, the hints implementation looks good, but have added some minor comments. Please address. @OlgaMaciaszek Thank you for your review. I have incorporated all your comments - except...