Andrew Querol

Results 9 comments of Andrew Querol

@yuraj11 @ddobrev I apologize for the really late response for addressing these issues. I have been slammed at work with a project leaving almost no free time. Your test SVG...

Just rebased and squashed as well to make this merge cleaner

Hi @IvanRibakov Thanks for the report! Are you able to post your entire `handleConnection` function? The context passed into there is indeed the running context which by default is just...

Thanks for sending over this additional information, I'll see if I can spot the issue going on. It may take me a bit to actually troubleshoot since I'm not with...

Hi @Stratoff, thanks for this report! Your first pass solution certainly looks like it could work for this and shouldn't hurt anything/cause issues with the library. However I think some...

Hi @williamflynt, there are some really good comments in here, thanks for sharing them! There shouldn't be any 5 second context timeout so this seems like a potential bug. The...

The deadline gets set from the caller, in your code it would be the context passed in from here. ```go if _, err := conn.SendCommand(ctx, command.API{ Command: "echo", Arguments: log.Sprintf("ping...

Some thoughts I have on the considerations outside of the 5 second disconnect issue. 1. I'm not positive if the documentation on not storing contexts in structs covers the use...

I do potentially see an overlooked path where the onDisconnect handler may not be called. It wouldn't explain your 5 second disconnect issue though.