Thanabodee Charoenpiriyakij
Thanabodee Charoenpiriyakij
> @wingyplus Any news on this PR? I'm ready to approve whenever you address changes :D Changelog added. I'm waiting for CI to be complete.
> @wingyplus It seems there's not conflict, please regenerate the dagger.gen.go client and then I can review :D Will fix in around 2-3 hours
@TomChv sorry for the delay. I rebased and squashed all the commits. 🙏
> Thanks for tackling the fix for this, I hit it yesterday and was happily surprised to see it was already being worked on. The changes here lgtm. > >...
@helderco what do you prefer between move all runtime files to `sdk/elixir` or still keep it inside the runtime directory except dagger.json?
@gmile Just FYI. :)
@gerhard Sorry for taking it so long. Rebased. 🙏
@helderco @jedevc I can finally relocate it to runtime with keeping dagger.json into the root of sdk/elixir. It's make me less happy than having runtime source in `sdk/elixir` because it...
@helderco @jedevc or i should wait for https://github.com/dagger/dagger/pull/7744 and use that to locate the sdk directory?
I do rebased and squash commit to remove noise commits. Ready to review again. 🙇