Thanabodee Charoenpiriyakij
Thanabodee Charoenpiriyakij
Thanks for reviewing @helderco. That was a huge comments! I'll take a look during this weekend. :)
@helderco Unfortunately, I can do only one integration tests because most of it required to have struct supported, which's not covered by this PR. And found test `TestModuleDescription` is not...
It seems testrace failed in `module_python_test.go`. Not sure why, so re-running it. :)
@helderco anything else I need to do to get it merge?
Rebased.
> @wingyplus, can you update instructions in the description now that it's not a built-in module? Sure!
> Hmmm... how do you pass the sdk's files when not a built-in runtime module? Have you been able to make it work? Oh. I may missing something, let me...
> Hmmm... how do you pass the sdk's files when not a built-in runtime module? Have you been able to make it work? @helderco That's my mistake 🙏 . Fixed...
> @wingyplus, can you update instructions in the description now that it's not a built-in module? Done. Also added to the README.md but it's need a little polish after merge.
@helderco sorry for response to you lately. Here is the test result.  I do test on commit https://github.com/dagger/dagger/pull/6967/commits/67bb3c7b83f98893b07a83cb81720362fefd1429 and switch back to dagger main branch on https://github.com/dagger/dagger/pull/6967/commits/2a918f80f93d7cfe38a6ee943ffbf6803ea24851