windingwind

Results 347 comments of windingwind

Thanks. I will check the tests

Seems like we have applied `wrap` to all fields in #4802, which is why the `noWrap` parameter does not work and fails the test. Can just remove the support to...

Fixed the tests, I think probably we still want to support plugins to add `noWrap` rows. > @windingwind: Leaving out the dataProvider try/catch now is correct, right? Yes, it would...

Thanks @AbeJellinek ! I moved the API definitions to `xpcom/pluginAPI`.

OK, squashed into 3 commits, should be fine to merge.

@abaevbog It took me some time to figure out how to implement a11y support with virtual focus, not sure if I am doing it right. It would be perfect if...

Also @yexingsha maybe we need some design here for the tabs menu with virtual selection. Here's what it looks like now: Thank you very much!

Thanks @abaevbog , I will improve it once we decide everything about the design. re @yexingsha : This seems to be putting more weight on the close button. Most of...

Thank you @yexingsha ! It looks like this now: If the implementation of the design if ok, I'll continue with the a11y improvements.

Thanks @yexingsha , should be fine now: