erabii
erabii
daaaamn! I never expected for this to be such a huge problem for us, until we needed to install some custom stuff inside the existing image for dev purposes _only_.
I agree with this bug, both clients should work the same. In general, I could fix this, but when I get my hands to it, unless there will be someone...
I'd like to take this issue and work on it. imho, we should be able to let users "opt-in" into this feature, so that it does not break existing apps....
while trying to implement this, I've hit a small problem. We can't have `spring.cloud.kubernetes.configmap.apps` as a label. There are two limitations: - it's value must be less then 63 characters...
nope, the last one will override all others. array is not supported either in labels
you do, but they are still key/value pairs. So something like this : ``` data: spring.cloud.kubernetes.configmap.apps: - spring-cloud-kubernetes-configuration-watcher-app-a - spring-cloud-kubernetes-configuration-watcher-app-b ``` is not supported.
in this case, watcher has to be restarted (manually or reload itself) whenever a service enters or leaves your domain. I do not see an issue to map that like...
exactly right!
sorry, forgot to comment here. I agree with the annotations approach and it makes sense.
The PR is out for review [here](https://github.com/spring-cloud/spring-cloud-kubernetes/pull/1067). I just want to put it for visibility here that we will delay the event posting, based on `spring.cloud.kubernetes.configuration.watcher.refreshDelay`, that by default is...