Sebastian Wilzbach

Results 538 comments of Sebastian Wilzbach
trafficstars

Current status: As I'm currently trying to get the CodeCov settings, it seems getting CodeCov to succeed to matter what, can be done with a combination of: - `require_ci_to_pass: false`...

> Bugfix without unittest We can get the diff nicely from the GH API: https://patch-diff.githubusercontent.com/raw/dlang/phobos/pull/4900.diff so the logic could be as simple as: ``` if (pr.hasIssueRefs()) { auto diff =...

I just found this CI tool: http://danger.systems They have a similar idea, though it seems to be targeted at Ruby codebases. In particular I like their clean summary: ![danger-screenshot-074f084c](https://cloud.githubusercontent.com/assets/4370550/22972130/af8c5ab0-f378-11e6-82e4-a626d815b7e0.png) A...

Especially forgetting to point bug fixes at `stable` happens quite often: https://github.com/dlang/tools/pull/218

> That seems like overkill. Why not just use a bare repo? Why? I explicitly want to test _what_ the bot will send to GitHub, so mocking the API seemed...

> It would make sense if dlang-bot had its own git client and SmartGit protocol implementation, but it doesn't - it uses the git shell commands, so I think it...

That's not done by dlang-bot per se. See https://github.com/dlang/dub/blob/master/.travis.yml and https://github.com/travis-ci/dpl/issues/234 and https://github.com/dlang/dub/issues/1367#issuecomment-366568829 > This cause all tools using the latest release to start using the beta immediately. No, they...

Uhm Buildkite always uses the get latest stable release script: https://github.com/dlang/ci/blob/master/buildkite/build_project.sh In short: ``` git ls-remote --tags https://github.com/dlang/dub | sed -n 's|.*refs/tags/\(v\?[0-9]*\.[0-9]*\.[0-9]*$\)|\1|p' | sort --version-sort | tail -n5 ``` ```...

![image](https://user-images.githubusercontent.com/4370550/47082965-9ae76b00-d20f-11e8-95e9-8babfcb5319b.png)

The real failure is: ``` [INFO] Running /var/lib/buildkite-agent/builds/buildkite-agent-05-1/dlang/dmd/build/dlang-dub/test/interactive-remove.sh... Package dub not found for registry at https://code.dlang.org/ (fallback ["registry at http://code.dlang.org/", "registry at https://code-mirror.dlang.io/", "registry at https://code-mirror2.dlang.io/", "registry at https://dub-registry.herokuapp.com/"]): No...