Brandon Wilson

Results 99 comments of Brandon Wilson

> Q: Should we have the same behavior for quote grant requests? @wilsonianb I'm not sure. Creating a quote can indirectly reveal the sender's available balance at the account provider....

Since we're assuming the RS and AS are operated by the same account provider, we can make token introspection http signature validation optional. The AS won't publicly expose that endpoint.

I think the following [mutations](https://github.com/interledger/rafiki/blob/main/packages/backend/src/graphql/schema.graphql#L36) are already idempotent: - `createAsset` - `updateAssetWithdrawalThreshold` - `updatePeer` - `deletePeer` - `addPeerLiquidity` - `addAssetLiquidity` - `createPeerLiquidityWithdrawal` - `createAssetLiquidityWithdrawal` - `createAccountWithdrawal` - `finalizeLiquidityWithdrawal` - `rollbackLiquidityWithdrawal`...

@matdehaast :point_up_2: thoughts?

- requires https://github.com/interledger/rafiki/issues/583 to obtain the GNAP auth token

The Open Payments OpenAPI spec defines the pagination query parameters as `oneOf` either forward or backwards pagination: https://github.com/interledger/open-payments/blob/f1b51c3c051c9030cea1f3d2542cfb492c4330d3/openapi/resource-server.yaml#L1203-L1207 I think that the libraries Rafiki's openapi validator middleware is using to...

@AlexLakatos @sabineschaller would either of you mind testing the endpoint with Rafiki using a version of the openapi with pagination as only forward or backwards (rename one of them as...

Another possible cause is that the openapi-request-coercer doesn't support "[exploding](https://spec.openapis.org/oas/v3.1.0#fixed-fields-9)" object parameter properties: https://github.com/kogosoftwarellc/open-api/blob/0ec45af8c35779b6aae611f8a13196b7d2bf75b9/packages/openapi-request-coercer/index.ts#L220-L222

I'm still encountering jest bigint serialization errors: ``` node:internal/child_process/serialization:120 const string = JSONStringify(message) + '\n'; ^ TypeError: Do not know how to serialize a BigInt at stringify () at writeChannelMessage...

This would require including the liquidity account balance in the query response. This could also be expanded to apply to incoming payments and payment pointers (SPSP)