rafiki icon indicating copy to clipboard operation
rafiki copied to clipboard

feat(auth): allow non-interactive grants for incoming payments

Open sabineschaller opened this issue 2 years ago • 2 comments

Changes proposed in this pull request

  • if the access type is incoming-payment, the grant will be issued right away, without interaction

Context

  • fixes #415

Checklist

  • [x] Related issues linked using fixes #number
  • [x] Tests added/updated
  • [ ] Documentation added
  • [ ] Make sure that all checks pass

sabineschaller avatar Sep 02 '22 10:09 sabineschaller

Q: Should we have the same behavior for quote grant requests? @wilsonianb

sabineschaller avatar Sep 02 '22 11:09 sabineschaller

Q: Should we have the same behavior for quote grant requests? @wilsonianb

I'm not sure. Creating a quote can indirectly reveal the sender's available balance at the account provider. OTOH a grant allowing quote creation is likely to also include outgoing payment creation, which would require interaction.

wilsonianb avatar Sep 02 '22 15:09 wilsonianb

Creating a quote can indirectly reveal the sender's available balance at the account provider. OTOH a grant allowing quote creation is likely to also include outgoing payment creation, which would require interaction.

Then let's leave it as is for now.

sabineschaller avatar Sep 05 '22 09:09 sabineschaller