Will Viles

Results 16 comments of Will Viles

Hi @xiwcx, thanks for bringing this to attention! Ember UserAgent uses [ua-parser-js](https://github.com/faisalman/ua-parser-js) under the hood. Perhaps you could open an issue over there and link back to it here for...

Merge this please!

Hey @queenvictoria, thanks for the PR! I'm not currently using this addon in an active project of mine, but I'll carve out some time very shortly to review this for...

@zacharygolba @matthewdias - I really like the idea of custom filter params. The suggested API looks great. With regard to #699, I suppose that's down to whether we think filtering...

I tend to agree that filtering by relationship ids/comparative operators should come out of the box. As for using filters on the related resource, that's a great idea. So `/articles?filter[tags][name]=foo`...

+1. I've created a [gist](https://gist.github.com/willviles/001e2a998a8f0c64862ab32e7082cebb) for what sounds like the same issue.

I found the offending code at [controller/utils/params-to-query.js#L53-L58](https://github.com/postlight/lux/blob/master/src/packages/controller/utils/params-to-query.js#L53-L58). Using `find` returns just the first relationship per related model. I've got `includedFields` returning all relationships by [looping over each relationship](https://github.com/willviles/lux/blob/fix-683/src/packages/controller/utils/params-to-query.js#L54-L74). However, there's...

Check out my fork of Lux (branch `fix-683`) to test this issue: https://github.com/willviles/lux/tree/fix-683

Here's the problem with the SQL aliasing. Unfortunately, when you put the LEFT_OUTER_JOIN alias as dot notation (e.g. `"avatar.id"`), it gets parsed as `"avatar"."id"`, whereas in the SELECT part of...

@jamemackson - you're right! Using the example of my gist, the following serializer config does indeed work: ```javascript // serializers/user.js attributes = [ ... 'avatarId', 'coverImageId' ]; hasOne = [...