Will Norris

Results 223 comments of Will Norris

I don't have any objection as long as is doesn't impact other users. I wonder how difficult it would be to capture and track which versions of GHE a given...

This issue was filed before GitHub Actions and repo secrets existed, hence the mention of a GCE instance. Today, this could pretty easily be implemented with actions, perhaps run on...

This is great, thanks! (And someone I missed seeing your original post back in February!) The last time I looked, the go libraries for OpenAPI were pretty lacking, which is...

oh wild... I also just realized that you're reverse engineering this from the API documentation. I really wish GitHub would officially publish something like this :-\ Though to be fair,...

We [already run](https://github.com/google/go-github/blob/master/.github/workflows/linter.yml) golangci-lint. We can just enable staticcheck [there](https://github.com/google/go-github/blob/master/.golangci.yml) (https://golangci-lint.run/usage/linters/)

apparently we explicitly disable staticcheck in https://github.com/google/go-github/blob/master/.golangci.yml, probably because it was failing at the time. What I will typically do with golangci-lint is check in the initial config with failing...

this was fixed a few months ago in a6f541de1b37f9d8bdde5d092c8fe8bbab542b10.

No, that was just an idea we had. We never ended up implementing it.

ignoring the resource parameter and always returning the same document isn't technically invalid, but seems like a bad practice we wouldn't want to encourage. It's not hard to setup rewrite...

I volunteer as tribute to submit and maintain the Firefox Add-on. I've been using the extension for a really long time, and have somewhat recently switch to Firefox as my...