Will Norris

Results 223 comments of Will Norris

A few years ago, I took Andy's great work here and expanded on it pretty significantly: https://github.com/willnorris/microformats. That's one of the only actively maintained microformats libraries in Go that I...

Sorry, I missed seeing this when it was originally submitted, but yeah this seems totally reasonable.

> * putting quotes around the ignore path yeah, this is one thing about ignore that I really don't love, but there's also little we can do about it. The...

I believe there is a bug or discussion somewhere about using doublestar for searching as well. I can't remember what the blocker at the time was 😕

I'm assuming this is simply a go versioning issue. If its something else, please feel free to provide more info.

I'll have to give some more thought to how I feel about changing the default behavior, but a few additional notes: - What @gmlewis said matches my recollection of why...

I mentioned this to @gauntface in chat as well, but repeating here for others. My comment about duplicating methods was not about overwriting the client.Do method, but rather providing alternate...

Oh, I certainly wasn't suggesting that we would put alternate implementations into go-github. The point was that if a user of go-github ever wanted to do something different than the...

I'm assuming Glenn meant `context.WithValue`. You could tuck a value into the context that indicated the API previews you wanted to enable or disable. Then the methods that would normally...

So from the user's perspective, it would be something like: ```go client := github.NewClient() ctx := context.Background() ctx = github.EnablePreviewFeatures(ctx, github.PreviewFoo, github.PreviewBar) // or alternately ctx = github.DisablePreviewFeatures(ctx, github.PreviewFoo, github.PreviewBar)...