Shinichi Maeshima
Shinichi Maeshima
@legacy370 Thanks for reporting this issue. Since there are no clear steps to reproduce it, we’re closing it for now. If you can provide more details, feel free to reopen...
@joshbuker While it would be ideal to continue supporting slightly older versions of Rails for the sake of users, the reality is that our maintenance resources are currently limited. Given...
@Spone Could you take a look at the failed CI?
Hi @jmarchello, I understand you might be quite busy, but whenever you have some time, could you please review this PR? Your input would be really valuable. Thanks so much!
Rebased the branch and resolved conflicts 😃
@joshbuker As far as I have reviewed, I think the implementation is fine, but I'm not sure if the comments and other texts are clear. Could you please review them?
@brendon I think the implementation in this PR is fine, but I’m not confident about the English wording or the method names. If anything looks off, please point it out.
I support the approach in this PR to first show a warning. Sorcery’s redirect_back_or_to prioritizes redirecting to the URL the user tried to access while not logged in (when that...
Since Sorcery now supports Rails 7.1 and above, we can use Rails.application.deprecators. I think that’s a great idea.
As shown in the Rails documentation, could you add deprecators like the following inside `sorcery/engine.rb`? https://api.rubyonrails.org/classes/ActiveSupport/Deprecation.html By doing this, the overall settings like the following will also apply to Sorcery’s...