Will Martin

Results 16 comments of Will Martin

Hey everyone! We are well aware of how much folks want official Svelte framework support. We need to do some more research, so we’re going to make this ticket the...

It looks like an error is thrown when instantiating a new color, perhaps we could use the same message? https://github.com/processing/p5.js/blob/e46fa4d5ad9ba4cad771ac7b7bc01d1f099f3fa3/src/color/p5.Color.js#L41 Additionally, should we just convert the `mode` argument to lowercase...

> Good catch. Shouldn't the constructor have a `super()` call? 🤔 Yep! Updated the code block.

Huh, doing the above repro and loading the same network resources, I get the following: Seeing this in Chrome, FF, and Safari.

Hi! Could I make a pull request for this issue?

Hi @splitinfinities, since we are just importing and exporting again, what is the benefit of an end user using the `path` methods exported here vs importing `path` in their own...

Hey @Gargron, I would love to try and submit a PR for this if that is cool :) Is that API currently documented, or should I look for it in...

> @danielleflinn Looks good! I couldn't get the Service stories to work on my end, but I assume that is a bug with chromatic not storybook. Yeah, I think it...

I wasn't properly passing the `title` from the service to the component, fixed in [2e30155](https://github.com/bitwarden/clients/pull/6490/commits/2e30155d79fd187ebe786c72d9497117e044ab16).

Latest commits fix the conflicts with https://github.com/bitwarden/clients/pull/8211 and removes the calls to `ngx-toastr` that were added to the `ForegroundPlatformUtilsService` (cc @MGibson1)