willkroboth

Results 82 comments of willkroboth

> In my own testing, I did notice the two consoles acted a bit differently > My understanding is that that is the very issue that we ended up actually...

TLDR; I tested my custom Brigadier suggestions using this patch. Unfortunately, it didn't quite work, and gave me this error: ``` [org.jline] Error while finding completion candidates java.lang.StringIndexOutOfBoundsException: begin 0,...

Cool, thank you! It does seem to work better, but unfortunately I still found some issues. --- The change does fix the usual suggestions. Before, typing `test a=1` would incorrectly...

> Ok, I think I handled suggestions with spaces correctly now. I had to build a custom parser to make sure words were created correctly and not separated purely on...

Ah, I'm not familiar with jline, but that makes sense. It's too bad you can't just plonk the suggestion down where Brigadier's `Suggestion` object says it should go.

This looks similar to #494. There is currently PR #501 that tries to fix #494. If you're able to, you could try using the CommandAPI branch for #501 and see...

Hm, yeah, I'm having trouble reproducing this. I was wondering, did you have any other plugins on the server when you first encountered this issue? Maybe there's another factor at...

Are you able to share a server log or the plugins you are using? That could help me replicate it to speed up investigation. If those are private, maybe you...

Ah, I think I figured out why the pool only uses one thread. From the [javadocs](https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ThreadPoolExecutor.html): > Queuing Any [BlockingQueue](https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/BlockingQueue.html) may be used to transfer and hold submitted tasks. The...

Hm, unfortunately, this fix does not solve the problem on all versions of Paper. The `COMMAND_SENDING_POOL` was only added by https://github.com/PaperMC/Paper/pull/8170 (build paper-1.19.2-117), so this PR only fixes the problem...