Will Dean
Will Dean
Feel free to close this one out @ColtAllen
Would this include upper funnel, lower funnel media examples?
This is breaking down into: - [ ] Add causal graph of current model (at top of notebook) @cetagostini - [ ] Potential to recover parameters when linear through controls...
Okay. let's wait on the wrapper then. If you can add markdown above instead of the comment, I think that would look a bit better and more clear about the...
The markdown cell is just empty. There should be some type of transition from the previous out of sample section into the budget optimizer section. Some markdown should facilitate that...
It seems like part of the problem: https://github.com/pymc-labs/pymc-marketing/blob/936270958f79fd3cce0488ae2301f2d8f3e2a35f/pymc_marketing/mmm/mmm.py#L2074-L2077
Seems like a pretty good workaround. Would you want to make a PR for this @AlfredoJF? Seems like a simple edit around these lines might do the trick: https://github.com/pymc-labs/pymc-marketing/blob/af946dfa8687a65018ddd4d708f434a7f32f30ab/pymc_marketing/mmm/mmm.py#L2091-L2094
Good catch @tim-mcwilliams So I am hearing you got it working with this fix, right? @cetagostini You can do checks on the dims in the priors at initialization in order...
Think this is ready for the initial release? @cetagostini @juanitorduz
All feedback should be included now @juanitorduz Is there a DataFrame that you have in mind that would fit the outstanding comment? I can add a test case for it...