Will Dean

Hearing few things here - [ ] allowing passing fourier class(es) to MMM - [ ] support weekly and daily fourier classes 2 is easier than 1 and probs should...

Good question. I think the easiest would be allow for a new parameter `monthly_seasonality` which would act like `yearly_seasonality` by taking an int or None. I like the idea of...

This is doable now by using the `mu_effects`. How do we want to handle this issue now?

The `adstock_max_lag` initialization parameter is deprecated / *should* warn that the class definition is recommended. The reason for going with the class isinitialziation is that there is additional parameters to...

> Thanks for the info! 😁 > > > > Docs I found: > > - [BaseMMM docstring](https://github.com/pymc-labs/pymc-marketing/blob/dffae874f94a115f34e06709f37297a91df74fbc/pymc_marketing/mmm/delayed_saturated_mmm.py#L84-L90) > > - [MMM Example Doc](https://www.pymc-marketing.io/en/stable/notebooks/mmm/mmm_example.html#id1) uses string adstock and saturation with...

> Oh nah this is from my notebook, no warning filter applied ☺️ Sounds good. Thanks for updating NOTE: I think notebooks have some amount of auto filtering. We should...

Hi @louismagowan Can we close this or make it a bit more specific

Yes, much of that tooling exists just maybe not all in MMM. If there are specifics, lets break down into smaller issues. Lets close this in favor of smaller issues

It is just a Protocol class https://github.com/pymc-labs/pymc-marketing/blob/2a4dd0362804577b971482ea192bf5e817a8eb43/pymc_marketing/mmm/budget_optimizer.py?plain=1#L86-L95 A user *should* be able to create a small wrapper class with the requirements. However, I don't know the complexity of that since...

> Resolved merge conflicts to resume work on this because it overlaps with #1377, #1356, and #1380. Thanks! > @williambdean Do you anticipate the Bass module inheriting from `ModelBuilder` in...