Will Dean
Will Dean
Would this have been addressed @juanitorduz ?
Closed with addition of `control_columns`
Try with extend_idata = False Do the mmm.model.coords have dates from fit data or predict data? Here is the notebook example. https://www.pymc-marketing.io/en/stable/notebooks/mmm/mmm_example.html#out-of-sample-predictions
> @wd60622 , Thank you. It got resolved!! Great. Happy it helped!
Hi @rym903 Any follow up questions here? If not, I can close out
The `scripts/parameter-recovery.py` script is good at checking for some inconsistencies.
The name `Plate` and `PlateMeta` come from the historical `get_plates` method of `ModelGraph`. However, get_plates also get scalars which were "" before and now `Plate(meta=None, variables=[...])` Is `Plate` still a...
> I'm okay with Plate or Cluster. Why the Meta in it? Meta would be information about the variables / plate to construct a plate label. Previously it was always...
> I don't love the word meta, it's too abstract. `Plate.dim_names, Plate.dim_lengths, Plate.vars`? or `Plate.var_names` if that's what we are storing I think itd be nice to keep the names...
> Is the question whether we represent a data structure that looks like (in terms of access): `((dims_names, dim_lengths), var_names)` vs `(dim_names, dim_lengths, var_names)`? Seems like a tiny detail. I...