Will Dean
Will Dean
Hi @kenteross , I see that that [the l_max is 50](https://gist.github.com/kenteross/0d49b07709282897bac267c6dff0b92b#file-slicing_adstock_eg-py-L198) Have you tried a smaller value? Does it cause issues with l_max = 5 or 10? Weekly datasets tend...
Are you also able to import the function from the package as well instead of copy and paste. I see the functions have changed and maybe there has been a...
> @wd60622 thanks for your suggestions! I tried reducing the l_max and importing the packages independently and it seems like the issue was coming from the l_max. It seems like...
> If I remember correctly just performing adstock with a large l_max would result in an issue. I can test it again tomorrow if you like. All good! Thank you...
Is this still of interest? I'm guessing that the current diagram is very stale!
Sounds great, then I will get to implementing! One of the aspects suggested from this example API is having the fourier transformations in pytensor. Any reasons against the switch from...
Can you display the `model_config` attribute for the model instance
Maybe good to have lower as 5.13.0 instead of 5.12.0 and get rid of the mutable deprecation warnings? Think one minor release difference for that is not too much Ref:...
Maybe this can be called out explicitly in https://www.pymc-marketing.io/en/stable/notebooks/general/other_nuts_samplers.html Thoughts @juanitorduz? Or maybe this is completed?
noticed that too ☹️