Will Holen
Will Holen
The objects are alive in the Hermes heap so more frequent GCs will not help. Manually freeing the blobs is a good workaround, but the associated XMLHttpRequests are still accumulating....
For # 2, the value returned is a [Runtime.RemoteObject](https://chromedevtools.github.io/devtools-protocol/tot/Runtime/#type-RemoteObject). It contains an object ID (here `1`) that you can pass to [Runtime.getProperties](https://chromedevtools.github.io/devtools-protocol/tot/Runtime/#method-getProperties) to iterate on properties. If you are expecting...
@RedMickey Oh, that's odd. Can you please verify that your version of the Hermes Inspector includes this commit? https://github.com/facebook/react-native/commit/f1a9ca04f63e3649afb798934811667de3e01fb4
The expected behavior is for the scriptId to be set if the breakpoint is resolved. There's a unit test that [verifies that this is the case](https://github.com/facebook/react-native/blob/33ccc0a0bc281f202d03eb2d7d136f783696b798/ReactCommon/hermes/inspector/chrome/tests/ConnectionTests.cpp#L738). How do I reproduce...
> @willholen, we tried to test this fix on `0.63.0-rc.0` version, but we faced the problem that when 'js-debug' extension sends `Debugger.enable` request, a Hermes app doesn't replies on it...
It turns out that at some point we removed fuzzy matching of breakpoint line&column because they resolved incorrectly. This means that if column 0 is just indenting, there's no code...
I've verified that change and it should be pushed out by the end of the day. Specifying a column of 0 will resolve to e.g. column 4, if there's four...
Please try out `Debugger.setInstrumentationBreakpoint` in https://github.com/facebook/react-native/commit/bf837d6373f536839c9cb3c93c2c106f44a4abc8 and let me know if it needs any further tweaks. Hermes does not currently fill in `hitBreakpoints` when it breaks on regular breakpoints, but...
`Debugger.runIfWaitingForDebugger` is implemented in https://github.com/facebook/react-native/commit/452cb9a78a02a7c61386f1ff0d6842c686d69929 @RedMickey React Native master is an especially fast moving target, and breaks like this is not uncommon. I would suggest following e.g. the [0.63-stable](https://github.com/facebook/react-native/tree/0.63-stable) branch...