Will Glynn

Checking `binutils` `readelf`, it appears that various other machine types use an identical build attributes scheme. I'll hoist `goblin::elf::arm::build_attributes` to `goblin::elf::build_attributes`. I don't like the duplication and control flow inversion...

That feels better. `pub struct Attributes` represents a parsed tag number and a bag of bytes containing both the attribute's data and subsequent unparsed attributes. Both types have fallible `pub(crate)`...

Well, I'm not happy with the test coverage but I got sidetracked before improving them and haven't returned to it yet. It seems to work though.

Ah, I believe that's moved from `…/dyldinfo args` to `/usr/bin/xcrun dyldinfo args`.

Content addressability is a must-have IMO. Test fixtures need to stay constant. Instead of saying "I want `test_case_4.exe`", it's better to say "I want the file with hash `012abc`.", since...

How about a `cargo` feature? ```rust #[cfg(test)] mod tests { // … #[cfg(feature = "external_data")] fn test_that_one_weird_thing() { let mut file = File::open("").unwrap(); // … } } ``` `--feature external_data`...

> hosts binaries @jan-auer I'm concerned about the legality of re-hosting e.g. Microsoft's binaries. It's fine for them to serve their files, but I don't see how anyone _except_ them...

@jan-auer What do you see as the ideal interface to this kind of external data? Not just `goblin`, but the whole ecosystem here. You've been through more of it than...

My sense is that the data structures and parsing belongs in a new `tbd` crate, and that `goblin` should have an optional `tbd` feature which pulls in that crate as...

YAML supports UTF-8, UTF-16, and UTF-32 in both byte orders (see [YAML 1.2 § 5.2](https://yaml.org/spec/1.2/spec.html#id2771184)). `&str` is specifically UTF-8, so perhaps we should use `TBD(&'a [u8])` instead. I've been assuming...