Will Crichton

Results 101 comments of Will Crichton

> Somehow I feel like it'd be better to structure the configuration as something like: > > ``` > [doc] > scrape-examples-targets = ["lib", "test"] > ``` > > rather...

> I thought this feature would be disabled by default? My understanding is that it would be disabled by default while unstable, and then enabled by default once stabilized. The...

The discussion about scraping-by-default-or-not has been pulled onto Zulip: https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/Enabling.20scrape.20examples.20by.20default

Ah thanks @lqd , got caught up in the rebase. I'll squash everything in a bit.

This PR is ready for review, although it needs a new Cargo reviewer since Alex has stepped back (is there a way to nominate a new reviewer?) As a reminder,...

It seems like only @ehuss is on [reviewer rotation](https://github.com/rust-lang/highfive/blob/master/highfive/configs/rust-lang/cargo.json) for Cargo right now, so I will add him. Sorry for all the extra work Eric :( r? @ehuss

My goal here is to provide a bigger roll out for this feature before fully stabilizing it. There's been a lot of back-and-forth on the UI, but those discussions were...

Ok that makes sense. Since this isn't stable yet, I restored the `-Zrustdoc-scrape-examples` flag. But now instead of passing `=all` or `=examples`, that configuration is still done at the target...

Update: I did a crater run of the scrape-examples feature as it exists on nightly on the top-10,000 crates (after implementing rust-lang/crater#626). In total there were 131 regressions. I could...

After some discussion with @jyn514 on Zulip, it's clear that a `Docscrape` unit should be able to fail without killing the build. Some crates (but not most!) will rely on...