Jeff Long

Results 284 comments of Jeff Long

Yes, it kind of leaves you wondering when it's doing something in the background. I just tried it for the heck of it .

A bunch of extra build/formatter stuff got checked in with the last push.

Can the id in the yml can go back to being `throttle` instead of `blocks_trickling_throttle`. It looks like the situations where this will help are - Simulations, where output widgets/printouts...

Deprecation (indefinite) sounds right. Would we want an Auto setting too, in that case, so users don't need to think about a magic max value for that?

On second thought, v3.10 will be around for a while, and having an orange/deprecated throttle block that everyone is still using doesn't seem right. No better idea yet. Let's make...

I was thinking that Auto (or Default) would be a separate mode in the GRC yml, and that would set the value to 0 internally. It seems a little non-intuitive...

Yes. I suppose "No Limit" is a more accurate name.

@marcusmueller I've been trying this out a bit, and have some suggested UI changes: - Default should be No Limit, since that's the old behavior. - The limit field should...

Since the tests all passed, can we assume that this actually is API compatible with existing `func(const sdt::string &)` calls? If so, then I don't see any problem with more...