Jeff Long
Jeff Long
That seems reasonable in this case.
Calling this one a bug fix, so backporting unless there are any objections.
Copying tags to propogate them probably isn't going to help performance.
This bug report comes from Gqrx, which locks/unlocks whenever a different demod is selected, for example.
Does anything count on `reset_nitem_counters` being reset? Seems like it would be much easier to just back out that change if not.
@mormj @dsorber any opinions on skipping reset of counters on lock/unlock? This was added as part of the custom buffers work.
If a change like this was made, changes to buffer.h and buffer.cc should be sufficient, since all the details of buffer indexing are private to the buffer class. 50 would...
@D-to-the-Romey : I see what you mean, now. That should work. I'm wondering why it wasn't done that way originally. ~~Maybe something to do with cache alignment?~~ (no probably not)
@D-to-the-Romey are you planning to work on a change for this?
@D-to-the-Romey it can wait for you - it's been this way for a long time.