Jeff Long
Jeff Long
Thanks. Agree there should be a mutex there, and also in other setters `set_rolloff()` and `set_filter_size()`.
That's right, and feel free to submit a PR if you're interested. The lock should be in work() and probably all of the setters.
@donnabranch do you have a simple flowgraph we could look at?
The semantics of `close()` are not obvious here. `open()` specifies the _next_ file to "play", and `close()` closes the _next_ file if there is one. Whether that interpretation of `close()`...
`file_sink` blackholes items while there is no open file, and does not terminate the flowgraph on `close()`. Then, to be symmetric, `file_source` should just block when there is no open...
Should files be closed on `stop()` and the re/opened on `start()`? That would make sense, and other sources/sinks do similar things. Currently `file_sink` does a flush on `stop()` but does...
`make()` without default arguments - are you talking about the top block `make(param_str)` at the bottom? If the PR is not done, could you mark it draft?
Do things other than numbers and double-quoted strings work in GRC with/without this PR? Booleans, lists, etc. I think you are correct that all specified parameters are provided. However, I'm...
@haakov could you take a look at this? Just noticed it's your code, so I will stop trying to figure out how this all works.
It sounds like the param fix is better than the way things are currently, but that it may not be complete. We'll put this on main but hold the backport...