Andy Wilkinson

Results 1279 comments of Andy Wilkinson

This has come up again in 3.4 when some changes in Oracle UCP have resulted in some new properties appearing in the metadata: 1. `spring.datasource.oracleucp.connection-wait-duration` 2. `spring.datasource.oracleucp.connection-wait-duration-in-millis` 3. `spring.datasource.oracleucp.hostname-resolver` We...

I like it although I'm not totally sure about the use of a separate file. I wonder if it would be better to use the existing `additional-spring-configuration-metadata.json` file. I think...

I think https://github.com/spring-projects/spring-boot/issues/13721 is another variant of this. Adding `@EnableRedisHttpSession` causes `RedisSessionConfiguration` to back off, but the condition evaluation report shows the following in the matched section: ``` RedisSessionConfiguration matched:...

I think you already tried that in https://github.com/spring-projects/spring-boot/commit/4aa4e14fa48a7224e7c5f9654874f08b3139c1d3. My guess is that the settings are getting clobbered by Java Format but that is just a guess. I tried doing this...

It'll fail by default with 3.4.0-SNAPSHOT due to the [deprecation of support for injecting `DynamicPropertyRegistry`](https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.4.0-RC1-Release-Notes#dynamic-properties-with-testcontainers).

@shawnweeks can you please update https://github.com/shawnweeks/spring_boot_testcontainers_restartscope_issue along those lines so that we can take a look?

See https://github.com/spring-projects/spring-boot/issues/42590#issue-2579203360 for an example of why this would be useful.

> How could the API be any simpler without duplicating? I'm not sure, however the pure Spring example in the [Kotlin blog post](https://spring.io/blog/2017/01/04/introducing-kotlin-support-in-spring-framework-5-0) involves less ceremony: ```java GenericApplicationContext context =...

Sounds like this might be turning into a documentation issue

Thanks for the offer, @sonu4578, but as indicated by the issue being labelled as "pending design work", we're not ready to accept contributions for this issue.