Andy Wilkinson comments

Results 1274 comments of


                                            Andy Wilkinson

Document additional user configuration that's required after setting `spring.hateoas.use-hal-as-default-json-media-type` to `false`

Sending HAL-formatted responses when accepting `application/json` should have been what happened in prior to 2.5. I'm almost certain that was the case with MVC and it was the intention with...

Document additional user configuration that's required after setting `spring.hateoas.use-hal-as-default-json-media-type` to `false`

Thanks for the sample. The problem is that Spring HATEOAS has customised the `Jackson2JsonEncoder` with a type-specific `ObjectMapper` registration for `org.springframework.hateoas.RepresentationModel` of which your `DemoResponse` is a subclass. This registration...

Document additional user configuration that's required after setting `spring.hateoas.use-hal-as-default-json-media-type` to `false`

In this particular case I think things would work if `selectObjectMapper` fell back to the default `ObjectMapper` when none of the registrations match rather than [returning `null` as it does...

Document additional user configuration that's required after setting `spring.hateoas.use-hal-as-default-json-media-type` to `false`

Spring HATEOAS doesn't register anything with the default object mapper so I'd expect the response to be in its default form rather than customised to match HAL. To verify this,...

Document additional user configuration that's required after setting `spring.hateoas.use-hal-as-default-json-media-type` to `false`

It's certainly an option, but I'd prefer not to have to take it. This feels like something that should just work by default but I think we'll need some changes...

Document additional user configuration that's required after setting `spring.hateoas.use-hal-as-default-json-media-type` to `false`

Thank you, @odrotbohm. I think we should turn this into a documentation issue. We can add something to [this section](https://docs.spring.io/spring-boot/docs/2.5.1/reference/htmlsingle/#features.developing-web-applications.spring-mvc.spring-hateoas) of the documentation about `spring.hateoas.use-hal-as-default-json-media-type` and the consequences of setting...

Document additional user configuration that's required after setting `spring.hateoas.use-hal-as-default-json-media-type` to `false`

I'm a little wary of doing that as it'll make it easy to do something that isn't supported, i.e. it's encouraging people to serialise a `RepresentationModel` as plain JSON. From...

Document additional user configuration that's required after setting `spring.hateoas.use-hal-as-default-json-media-type` to `false`

@tmc9031 There hasn't been any changes in this area in Spring Boot 2.7. I see you've also commented on https://github.com/spring-projects/spring-data-rest/issues/2132. Please don't ask what is essentially the same question on...

Document additional user configuration that's required after setting `spring.hateoas.use-hal-as-default-json-media-type` to `false`

@tmc9031 The comments above describe your options. You should set the property and then define your own `HypermediaMappingInformation` or `HalConfiguration`. There's an example of the former in [this comment](https://github.com/spring-projects/spring-boot/issues/26814#issuecomment-858555232). If...

Change phases of WebServer start-stop and graceful shutdown lifecycles to allow other smart lifecycles to run before graceful shutdown

We discussed this today and we'd prefer not to make the phase externally configurable as the phases of `WebServerGracefulShutdownLifecycle` and `WebServerStartStopLifecycle` need to be configured correctly in relation to each...