Michael Wilkerson

Results 11 comments of Michael Wilkerson

Hey @thisisommore, thanks for taking a look at this! This solution definitely is an improvement towards querying and computer parsing. After doing some investigation myself, I realised that the log...

> Hey @wilkermichael I have a few questions > > * What can be done here? > Should this field be omitted in json using `json:"-"` > https://github.com/hashicorp/consul-terraform-sync/blob/cf630a15e69a6342fe44fd7434283022b36b457c/config/condition_catalog_services.go#L12-L14 > *...

> @wilkermichael do I have a write the test for each struct? @thisisommore thanks for your patience, I've been on holidays the last couple of weeks. I think it would...

> @wilkermichael Thanks for addressing this, I have committed the changes, and now will try creating tests. You can review my changes and let me know if any change is...

@thisisommore Happy New Year! No rush on this, take your time. I probably won't get a chance to review until next week.

@thisisommore I changed some settings on our end as I noticed that the pipeline wasn't running for your PR. The checks should now show the areas where the PR is...

You can ignore the Slack failure, that one is on our end. It requires a setting change, but won't affect your PR. EDIT: This has been resolved now in the...

Investigation Results: **How does it affect CTS** - This affects all "block" HCL definitions in CTS, all of which will handle an array but not a map using the current...

Hello @fransafu, that's great that you've taken interest in this issue, and thanks again for your previous contribution! If you're still interested in giving this enhancement a try, let me...

Hello @thisisommore Hacktoberfest is now over, but we still value community contributions to the project! If you're still interested in contributing, feel free to submit a PR.