Wiard van Rij

Results 61 comments of Wiard van Rij

Have you seen how Loki implements this as well? Might give some inspiration (not sure if relevant tho). For example limiting on bytes/s might also be useful. Anyhow, sounds really...

LGTM, though it should get some more actionable items IMO :)

I will test this on my own branch and see if we can make part of our release strategy.

Hey @chaudum, since I've been in a similar situation, let me share my perspective. Firstly, I understand your point about it being an experimental feature. We're simply eager to explore...

One 'fix' (or better yet, read the config and set it right) was to change: https://grafana.com/docs/loki/latest/configure/#storage_config ``` bloom_shipper: # Working directory to store downloaded bloom blocks. Supports multiple # directories,...

@dotdc Yea I understand. If I may argue tho; I personally think the out of the box experience for users is going to be much better with Recreate. I looked...

p.s. Updated the MR to only reflect the doc update

I actually had a conversation on the CNCF slack: https://cloud-native.slack.com/archives/C167KFM6C/p1702998798043709?thread_ts=1702895323.133249&cid=C167KFM6C Basically the gist there is: https://github.com/prometheus-community/helm-charts/blob/ef3fe76dbb88ce712eaae22e8e14a868d41df061/charts/kube-state-metrics/values.yaml#L35-L40 ``` # Change the deployment strategy when autosharding is disabled # updateStrategy: Recreate ```...

Heh, well regarding: > In some cases, having duplicated data is better than no data That's actually a 'funny' one, because while in essence I would agree, the truth is...

Could you fill in the other topics; What you expected to happen: How to reproduce it (as minimally and precisely as possible): Full logs to relevant components: Anything else we...