Logging: Simplify and adjust request logging configuration

[matej-g]

As seems to stem from the discussion in https://github.com/thanos-io/thanos/pull/4934, request logging implementation and configuration seem to have a couple of confusing features, which might be a bit misleading for the users.

I'll try to summarize some of my and @PhilipGough's observations below:

• There is no simple way to determine if the request logging for a component has taken effect - perhaps it would make sense to log a line with this information (e.g. "logging for XY has been enabled")
• A configuration to log requests for particular server (HTTP, gRPC) on a component requires to specify a port, but it is not clear which port the user should specify and why this is required. Perhaps specifying the port is not necessary?
• It is possible to configure a log level for the requests logs, but the logs still do not seem to appear until log.level=debug is used. I think normal user expectation would be to set the level and see the logs being logged at that level, without the need to set log.level=debug.
• URL path configuration seems to be working on the basis of exact match, per the comment in https://github.com/thanos-io/thanos/pull/4934#discussion_r769768126, but this is insufficient if URL parameters are passed as well.

[matej-g]

There's already https://github.com/thanos-io/thanos/pull/4956 to address the log level portion of this issue.

[wiardvanrij]

LGTM, though it should get some more actionable items IMO :)

[stale[bot]]

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[B0go]

Hello, I am interested in doing my first contribution to the Thanos project and I think this issue may be a good one to start! I have a good knowledge on Thanos as an user and I still need to study the code and configure the dev environment... so it may take some time

[matej-g]

Hey @B0go, sorry for the late reply! Please go ahead, feel free to take your time to familiarize yourself with the code, and don't hesitate to ask if something's not clear :slightly_smiling_face:

[stale[bot]]

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale[bot]]

Hello 👋 Looks like there was no activity on this issue for the last two months. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[theluckiesthuman]

Hey @matej-g. I want to contribute to Thanos. As no one is working on this issue, I am working on it.

[ReticentFacade]

@matej-g, I'm willing to work on this issue. Could you please share the steps to reproduce?