Wyatt

Results 65 comments of Wyatt

@rbs-jacob can you review this?

Hi @Tanmoy741127, I've assigned you this issue. Make sure to look at the [contributing guide](https://github.com/redballoonsecurity/ofrak/blob/master/docs/contributor-guide/getting-started.md). Thanks for your interest in helping out!

@The-Debarghya, `7z` is run in two places: - https://github.com/redballoonsecurity/ofrak/blob/master/ofrak_components/ofrak_components/p7zip.py#L48 - https://github.com/redballoonsecurity/ofrak/blob/master/ofrak_components/ofrak_components/p7zip.py#L68 Variables using the name `p7zip` should be updated to use 7zip. Instructions/code that installs `p7zip` should also be updated...

Either `sevenzip` or `seven_zip` probably make sense (based on https://peps.python.org/pep-0008/#function-and-variable-names). Regarding the filenames that sounds fine.

@andresito00, @EdwardLarson, can you review this Draft MR. Especially review: - the methods that I propose to delete. It seems that we don't need them; if they become necessary we...

@EdwardLarson I think this is ready for review. I've updated the PR description with more details.

@EdwardLarson I've addressed the comments and updated the PR to include full function test coverage for Resource.

@ANogin, if I understand the intent behind this PR, you are looking for a way to install OFRAK from source natively. Did you consider building a Makefile target to do...