Manatsawin Hanmongkolchai

Results 23 comments of Manatsawin Hanmongkolchai

I also have types for svelte-state-renderer ready, however it depends on [@pyoner/svelte-typescript](https://github.com/pyoner/svelte-typescript/blob/master/packages/types/types/svelte/svelte.d.ts) which is probably not yet the community's standard? Here it is: ```typescript declare module 'svelte-state-renderer' { import {Renderer,...

I found out that the EventEmitter3 types require EventEmitter3 4.0 to be able to typecheck event handlers. Is it ok for me to bump? The only relevant breaking changes is...

Just a quick update, I'm still waiting on https://github.com/SamVerschueren/tsd/issues/45 , seems that adding types to the root will make it check node_modules as well.

I don't have anything else to add, so let's merge it

I think it is better just to bump semver-major? I think it is better than monkeypatching the libraries we use to emulate compatibility.

I've updated with the 2 changes @sw-clough have listed. Thanks for your review

How about checking for container name that starts with tmp?

I ran into this problem too. On a brief debugging, it seems that tern server is running in the browser environment and not node. It seems that 41d07635d25f9871a55d187578c4f40373faf30f may fix...

The spec (linked in OP) also mention origin, referrer, referrerPolicy, mode (only if it was 'navigate', I doubt that it is valid for our use case?) as all the fields...

Updated according to reviews