Will Holmgren

Results 118 comments of Will Holmgren

After reviewing all of the above, the only thing that I am moderately opposed to is dictionary input because it is not self-documenting. I previously commented: > Another thought is...

@mikofski brought up something similar in #235. I agree that the ``pvsystem.py`` module has grown to a difficult to mange length. Would you rather see the module broken up by...

Good points @jforbess and @cwhanse. Looking only at the "easier" ideas... I think the only io related functions are ``retrieve_sam`` and ``_parse_raw_sam_df``. Moving those would be an improvement of 130...

@thunderfish24 thanks for the detailed proposal. Do you know of any python packages that use a similar structure, in particular separating out the core code at the root level? The...

@kanderso-nrel I just tagged an alpha release after merging #1495. We should double check that installs as expected and then merge this one and perhaps make another alpha release

I thought [editable installs do not work](https://github.com/pvlib/pvlib-python/discussions/1486#discussioncomment-3085581) with this pattern. That would destroy my workflow. No objection to the change in version string format. I'm guessing we'll want to make...

Seems to work. I did the following 1. check out branch 2. activate conda env with existing pvlib dev installation 3. import pvlib. `pvlib.__version__` returns 0.7.2 (that's what was checked...

@jules-ch can you resolve the merge conflicts?

thanks @jules-ch! let's see how it goes...

One thing that I failed to test above... make a change, then check the version *without reinstalling*. It used to be the case that versioneer would immediately report `.dirty` or,...